alamb commented on a change in pull request #1699:
URL: https://github.com/apache/arrow-datafusion/pull/1699#discussion_r795161808
##########
File path: datafusion/src/execution/dataframe_impl.rs
##########
@@ -62,6 +68,60 @@ impl DataFrameImpl {
}
}
+#[async_trait]
+impl TableProvider for DataFrameImpl {
Review comment:
I think @houqp was suggesting changing
```rust
trait DataFrame {
...
}
```
To something like
```rust
trait DataFrame:: TableProvider {
}
```
And then `impl TableProvider` for `DataFrame` (rather than `DataFrameImpl`)
-- which would mean that any `&dyn DataFrame` could be used as a table provider
If this is interesting, I am happy to file a ticket describing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
