houqp commented on pull request #1712: URL: https://github.com/apache/arrow-datafusion/pull/1712#issuecomment-1025266914
As for the first issue you mentioned, I think we need to avoid referencing both `DataFrameImpl` and `ExecutionContext` within the default TableProvider implementation because these two types are specific to the `DataFrameImpl` implementation of the trait. However, now that we don't have a separate Dataframe implementation in ballista anymore, I am not sure what we still gain from having the `DataFrame` trait defined. @andygrove @realno @yahoNanJing @alamb @Dandandan do you think it makes sense to just replace `DataFrameImpl` with `Dataframe` now and get rid of all the trait object overhead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
