zeroshade commented on pull request #12158: URL: https://github.com/apache/arrow/pull/12158#issuecomment-1025935325
Hey @brancz The reason for a lack of `StringDictionaryBuilder` is that it's really just a special case of the `BinaryDictionaryBuilder` which can be instantiated with the proper `arrow.DataType` and accepts adding either `[]byte` or `string`. So rather than create a separate `StringDictionaryBuilder` I just rolled it into that. Alternatively I could create a `StringDictionaryBuilder` which is just an alias to the `BinaryDictionaryBuilder` if that might be easier to understand? As for Lists, in the most technical sense nothing in the Arrow format spec prohibits or prevents using a List array as a dictionary. I just simply didn't implement it yet in this PR as that is not a case covered by the integration tests. I'd love any feedback on the API from real world usage! I'm still waiting on people looking through and reviewing this and so on, and was aiming to not merge this until after arrow version 7.0.0 gets released anyways. So i'd integrate any feedback you have into this PR. Looking forward to it and thanks for checking this out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
