alamb commented on a change in pull request #1717:
URL: https://github.com/apache/arrow-datafusion/pull/1717#discussion_r795930163
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -971,6 +973,58 @@ impl Expr {
Ok(expr)
}
}
+
+ /// Simplifies this [`Expr`]`s as much as possible, evaluating
+ /// constants and applying algebraic simplifications
+ ///
+ /// # Example:
+ /// `b > 2 AND b > 2`
+ /// can be written to
+ /// `b > 2`
+ ///
+ /// ```
+ /// use datafusion::logical_plan::*;
+ /// use datafusion::error::Result;
+ /// use datafusion::execution::context::ExecutionProps;
+ ///
+ /// /// Simple implementation that provides `Simplifier` the information
it needs
+ /// #[derive(Default)]
+ /// struct Info {
+ /// execution_props: ExecutionProps,
+ /// };
+ ///
+ /// impl SimplifyInfo for Info {
+ /// fn is_boolean_type(&self, expr: &Expr) -> Result<bool> {
+ /// Ok(false)
+ /// }
+ /// fn nullable(&self, expr: &Expr) -> Result<bool> {
+ /// Ok(true)
+ /// }
+ /// fn execution_props(&self) -> &ExecutionProps {
+ /// &self.execution_props
+ /// }
+ /// }
+ ///
+ /// // b < 2
+ /// let b_lt_2 = col("b").gt(lit(2));
+ ///
+ /// // (b < 2) OR (b < 2)
+ /// let expr = b_lt_2.clone().or(b_lt_2.clone());
+ ///
+ /// // (b < 2) OR (b < 2) --> (b < 2)
+ /// let expr = expr.simplify(&Info::default()).unwrap();
+ /// assert_eq!(expr, b_lt_2);
+ /// ```
+ pub fn simplify<S: SimplifyInfo>(self, info: &S) -> Result<Self> {
Review comment:
here is the new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
