tustvold commented on a change in pull request #1719:
URL: https://github.com/apache/arrow-datafusion/pull/1719#discussion_r796010059
##########
File path: datafusion/src/optimizer/simplify_expressions.rs
##########
@@ -1291,6 +1337,11 @@ mod tests {
#[test]
fn simplify_expr_case_when_then_else() {
+ // CASE WHERE c2 != false THEN "ok" == "not_ok" ELSE c2 == true
Review comment:
Unfortunately the optimizer is not especially brilliant at optimizing
boolean expressions - I've created #1716 to track this.
I'm not sure if we want to constrain the rewrite until the boolean
expression optimizer is able to more effectively reduce down what it produces...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
