alamb commented on issue #1716:
URL: 
https://github.com/apache/arrow-datafusion/issues/1716#issuecomment-1026219583


   > Does something similar also hold for things like A AND false? Just 
wondering if the existing logic handles this correctly... 🤔
   
   Yes. In fact @NGA-TRAN fixed a bug related to that in 
https://github.com/apache/arrow-datafusion/pull/1245 -- I think we have it 
sufficiently tested now. 
   
   See some of the rules here
   
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/optimizer/simplify_expressions.rs#L568
   
   It actually turn out that `A AND false` is always false (even if `A` is 
NULL) 
   
   However, `A OR false` could be `NULL` or `false`
   
   🤯
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to