jvanstraten commented on a change in pull request #12279: URL: https://github.com/apache/arrow/pull/12279#discussion_r796460348
########## File path: cpp/examples/arrow/engine_substrait_consumption.cc ########## @@ -0,0 +1,187 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <arrow/api.h> +#include <arrow/compute/api.h> +#include <arrow/compute/exec/options.h> +#include <arrow/engine/substrait/serde.h> + +#include <cstdlib> +#include <iostream> +#include <memory> +#include <vector> + +namespace eng = ::arrow::engine; +namespace cp = ::arrow::compute; + +#define ABORT_ON_FAILURE(expr) \ Review comment: It looks to me like the macro was just copy-pasted from one of the other examples. Four out of the six other examples in the directory make use of it, one uses your suggestion, and the remaining one does more complicated error handling. So I'll leave it as is based on precedence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
