lidavidm commented on a change in pull request #12014:
URL: https://github.com/apache/arrow/pull/12014#discussion_r797106217
##########
File path: dev/archery/archery/integration/tester_cpp.py
##########
@@ -60,6 +60,10 @@ def _run(self, arrow_path=None, json_path=None,
command='VALIDATE',
if quirks:
if "no_decimal_validate" in quirks:
cmd.append("--validate_decimals=false")
+ if "no_date64_validate" in quirks:
+ cmd.append("--validate_date64=false")
+ if "no_times_validate" in quirks:
+ cmd.append("--validate_times=false")
Review comment:
Just a question - do all existing files have invalid times generated, or
just some? Since it seems the current code path is correct, so presumably it
was fixed a while back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]