jvanstraten commented on a change in pull request #12279:
URL: https://github.com/apache/arrow/pull/12279#discussion_r797492993
##########
File path: cpp/src/arrow/datum.h
##########
@@ -153,6 +153,13 @@ struct ARROW_EXPORT Datum {
: Datum(std::shared_ptr<typename std::conditional<IsArray, Array,
Scalar>::type>(
Review comment:
I've been staring at this code for a long time now and I *think* 4b55dee
indeed avoids a copy? Also, the `std::move` on `T&&` in the template below
should be a `std::forward` according to my my linter, and that makes sense to
me, so I changed that one as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
