dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r797530348
##########
File path: r/src/type_infer.cpp
##########
@@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType>
InferArrowTypeFromVector<INTSXP>(SEXP x) {
} else if (Rf_inherits(x, "POSIXct")) {
auto tzone_sexp = Rf_getAttrib(x, symbols::tzone);
if (Rf_isNull(tzone_sexp)) {
Review comment:
It looks like we do not need to handle `tzone_sexp = ""` since both `TZ
= NA` and `TZ = ""` result in the `"tzone"` attribute being NULL. Added a
couple of expectations to reflect this.
https://github.com/dragosmg/arrow/blob/341640c1fae059c04501b734438d94241482abda/r/tests/testthat/test-Array.R#L266
https://github.com/dragosmg/arrow/blob/341640c1fae059c04501b734438d94241482abda/r/tests/testthat/test-Array.R#L282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
