jvanstraten commented on a change in pull request #12279:
URL: https://github.com/apache/arrow/pull/12279#discussion_r798582530
##########
File path: cpp/src/arrow/datum.h
##########
@@ -153,6 +153,13 @@ struct ARROW_EXPORT Datum {
: Datum(std::shared_ptr<typename std::conditional<IsArray, Array,
Scalar>::type>(
Review comment:
That looks right to me, I didn't consider what `std::make_shared<T>`
would do. Changed in 736c7a6, which compiles and passes all tests I run locally
(fingers crossed for CI). I personally find universal references extremely
confusing and usually end up throwing stuff at the compiler and seeing what
sticks, which is not exactly a great approach with templates...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
