thisisnic commented on a change in pull request #11971:
URL: https://github.com/apache/arrow/pull/11971#discussion_r798710717



##########
File path: r/R/csv.R
##########
@@ -707,7 +707,7 @@ write_csv_arrow <- function(x,
     x <- Table$create(x)
   }
 
-  assert_that(is_writable_table(x))
+  assert_that(is_writable_table(x) || inherits(x, "FileSystemDataset"))

Review comment:
       I've updated it now to support `arrow_dplyr_query` and the more generic 
`Dataset` instead of specific subtypes, but I don't think we actually want it 
to take `RecordBatchReader` objects, as creating them directly is part of the 
lower-level API. Do you agree?  If so I'll update the title here and on JIRA.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to