jonkeane commented on pull request #12185: URL: https://github.com/apache/arrow/pull/12185#issuecomment-1029462418
You're right — it wasn't the linter that was an issue, but there was a function from a previous PR that was causing documentation issues here. I've pushed those docs so that this builds cleanly (and so we didn't conflict or have the builds failing when this is merged — it's a bit unclean in that it's an extra bit of code, but that's ok for this) I also simplified one of the tests `"Dataset min_rows_per_group"` The for loop + if clause was behaving strangely for me (when I ran it fresh it would always only do the else clause). Regardless, I noticed that the order of which record batch will have the left over row in it isn't deterministic, so we can't check the final element. Instead I'm checking that only one of the row group sizes is less than the min. I also rebased so that we can get the version bump (which was causing a few of the CI jobs to complain) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
