alamb commented on a change in pull request #1743:
URL: https://github.com/apache/arrow-datafusion/pull/1743#discussion_r799012598
##########
File path: datafusion/src/execution/context.rs
##########
@@ -1347,100 +1347,6 @@ mod tests {
));
}
- #[test]
- fn optimize_explain() {
- let schema = Schema::new(vec![Field::new("id", DataType::Int32,
false)]);
-
- let plan = LogicalPlanBuilder::scan_empty(Some("employee"), &schema,
None)
- .unwrap()
- .explain(true, false)
- .unwrap()
- .build()
- .unwrap();
-
- if let LogicalPlan::Explain(e) = &plan {
- assert_eq!(e.stringified_plans.len(), 1);
- } else {
- panic!("plan was not an explain: {:?}", plan);
- }
-
- // now optimize the plan and expect to see more plans
- let optimized_plan = ExecutionContext::new().optimize(&plan).unwrap();
- if let LogicalPlan::Explain(e) = &optimized_plan {
- // should have more than one plan
- assert!(
- e.stringified_plans.len() > 1,
- "plans: {:#?}",
- e.stringified_plans
- );
- // should have at least one optimized plan
- let opt = e
- .stringified_plans
- .iter()
- .any(|p| matches!(p.plan_type, PlanType::OptimizedLogicalPlan
{ .. }));
-
- assert!(opt, "plans: {:#?}", e.stringified_plans);
- } else {
- panic!("plan was not an explain: {:?}", plan);
- }
- }
-
- #[tokio::test]
- async fn parallel_projection() -> Result<()> {
Review comment:
this test and those below are just moved into sql_integration test
##########
File path: datafusion/tests/sql/projection.rs
##########
@@ -73,3 +76,192 @@ async fn csv_query_group_by_avg_with_projection() ->
Result<()> {
assert_batches_sorted_eq!(expected, &actual);
Ok(())
}
+
+#[tokio::test]
Review comment:
These tests were just moved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
