Dandandan commented on a change in pull request #1730:
URL: https://github.com/apache/arrow-datafusion/pull/1730#discussion_r800084042
##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -333,8 +334,10 @@ impl ExecutionPlan for HashJoinExec {
concat_batches(&self.left.schema(), &batches,
num_rows)?;
let left_side = Arc::new((hashmap, single_batch));
-
- *build_side = Some(left_side.clone());
+ {
Review comment:
I tested this locally, also getting better performance after the
change(!) for query 8.
It suggests we are doing something wrong maybe with locking (e.g. stalling
some work), or we somehow perform less work in this PR? I didn't check whether
we still get the right results yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
