emkornfield commented on a change in pull request #12158:
URL: https://github.com/apache/arrow/pull/12158#discussion_r800129769
##########
File path: go/arrow/ipc/file_reader.go
##########
@@ -157,22 +162,9 @@ func (f *FileReader) readSchema() error {
return err
}
- id, dict, err := readDictionary(msg.meta, f.fields, f.r)
- msg.Release()
- if err != nil {
- return xerrors.Errorf("arrow/ipc: could not read
dictionary %d from file: %w", i, err)
+ if _, err = readDictionary(&f.memo, msg.meta,
bytes.NewReader(msg.body.Bytes()), f.mem); err != nil {
Review comment:
might be worth a comment on why update or delta is ignored? (maybe also
validate that it is of the expected type).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
