lidavidm commented on a change in pull request #12344:
URL: https://github.com/apache/arrow/pull/12344#discussion_r800660834
##########
File path: cpp/src/arrow/flight/server.h
##########
@@ -200,10 +201,11 @@ class ARROW_FLIGHT_EXPORT FlightServerBase {
int GotSignal() const;
/// \brief Shut down the server. Can be called from signal handler or another
- /// thread while Serve() blocks.
+ /// thread while Serve() blocks. Optionally a deadline can be set. Once the
+ /// the deadline expires all pending calls associated with the server will be
+ /// forcefully canceled.
Review comment:
Ah, sorry, Flight does not use async gRPC at all. So what I mean is
basically, "even if the deadline expires, this method will wait for existing
calls to finish", or "the deadline does nothing" (right now
:slightly_smiling_face:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
