domodwyer commented on a change in pull request #1729:
URL: https://github.com/apache/arrow-datafusion/pull/1729#discussion_r800695370
##########
File path: datafusion/src/physical_plan/coercion_rule/aggregate_rule.rs
##########
@@ -154,6 +155,15 @@ pub(crate) fn coerce_types(
}
Ok(input_types.to_vec())
}
+ AggregateFunction::ApproxMedian => {
+ if !is_approx_median_support_arg_type(&input_types[0]) {
Review comment:
Perhaps this could use `is_approx_percentile_cont_supported_arg_type` to
ensure it doesn't ever drift from the underlying implementation and remove
duplication?
##########
File path: datafusion/src/physical_plan/expressions/approx_median_old.rs
##########
@@ -0,0 +1,320 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Looks like `approx_median_old.rs` is checked in by accident after the
rewrite 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
