thisisnic commented on a change in pull request #12360: URL: https://github.com/apache/arrow/pull/12360#discussion_r801074767
########## File path: r/vignettes/developing.Rmd ########## @@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa at a high-level. If you're looking for more detailed content, you may want to look at one of the following links: -* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html) -* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html) +* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup) +* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks) Review comment: This will be fine for the CRAN checks, but once the pkgdown website is updated, these URLs will just point to the web version of the vignette where technically those sections will no longer exist. Maybe we want to change "you may want to look at one of the following links" to "please refer to the "Developers" section on our pkgdown site" and then remove those links, though this is still clunky as we can't link to the right URL until after the site is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
