alamb commented on a change in pull request #1273:
URL: https://github.com/apache/arrow-rs/pull/1273#discussion_r801556200
##########
File path: parquet/src/encodings/decoding.rs
##########
@@ -1340,11 +1340,11 @@ mod tests {
#[allow(clippy::wrong_self_convention)]
fn to_byte_array(data: &[bool]) -> Vec<u8> {
let mut v = vec![];
- for i in 0..data.len() {
+ for (i, item) in data.iter().enumerate() {
if i % 8 == 0 {
v.push(0);
}
- if data[i] {
+ if *item {
Review comment:
this type of change is not only more "idiomatic" I think it will also be
faster (as bounds checks aren't being done on each access of `data` 👍 )
##########
File path: parquet/src/encodings/levels.rs
##########
@@ -50,11 +50,11 @@ pub fn max_buffer_size(
}
/// Encoder for definition/repetition levels.
-/// Currently only supports RLE and BIT_PACKED (dev/null) encoding, including
v2.
+/// Currently only supports Rle and BitPacked (dev/null) encoding, including
v2.
pub enum LevelEncoder {
Review comment:
This is technically a breaking API change, but I think it is ok
##########
File path: parquet/src/lib.rs
##########
@@ -30,24 +30,13 @@
//!
//! 3. [arrow::async_reader] for `async` reading and writing parquet
//! files to Arrow `RecordBatch`es (requires the `async` feature).
-#![allow(incomplete_features)]
#![allow(dead_code)]
#![allow(non_camel_case_types)]
#![allow(
Review comment:
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
