alamb commented on a change in pull request #1783:
URL: https://github.com/apache/arrow-datafusion/pull/1783#discussion_r801566206
##########
File path: ballista/rust/executor/src/main.rs
##########
@@ -112,6 +116,21 @@ async fn main() -> Result<()> {
.context("Could not connect to scheduler")?;
let scheduler_policy = opt.task_scheduling_policy;
+ let cleanup_ttl = opt.executor_cleanup_ttl;
Review comment:
I wonder if it might be possible to use `NamedTempFile` or some other
struct from `tempfile` (already a dependency): https://crates.io/crates/tempfile
There are at least two benefits:
1. The files are dropped immediately after they are no longer used so
required intermediate diskspace is minimized
2. They can't be accidentally dropped while still in use (which perhaps
affects long running queries)
I did something similar in DataFusion here:
https://github.com/apache/arrow-datafusion/pull/1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
