Crystrix commented on a change in pull request #12369:
URL: https://github.com/apache/arrow/pull/12369#discussion_r801794165
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -2586,7 +2592,8 @@ Result<Datum> GroupBy(const std::vector<Datum>&
arguments, const std::vector<Dat
// start "streaming" execution
ExecBatch key_batch, argument_batch;
- while (argument_batch_iterator->Next(&argument_batch) &&
+ while ((argument_batch_iterator == NULLPTR ||
+ argument_batch_iterator->Next(&argument_batch)) &&
Review comment:
`argument_batch_iterator == NULLPTR` means there are no arguments, the
reading and check of argument_batch can be skipped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
