alamb commented on a change in pull request #1762:
URL: https://github.com/apache/arrow-datafusion/pull/1762#discussion_r801846583
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -21,379 +21,20 @@
pub use super::Operator;
use crate::error::{DataFusionError, Result};
use crate::logical_plan::ExprSchemable;
-use crate::logical_plan::{window_frames, DFField, DFSchema};
-use crate::physical_plan::functions::Volatility;
-use crate::physical_plan::{aggregates, functions, udf::ScalarUDF,
window_functions};
+use crate::logical_plan::{DFField, DFSchema};
Review comment:
not much left in this module 👍
##########
File path: datafusion-expr/src/expr.rs
##########
@@ -0,0 +1,705 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
The big one!
##########
File path: datafusion-expr/src/columnar_value.rs
##########
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use arrow::array::ArrayRef;
+use arrow::array::NullArray;
+use arrow::datatypes::DataType;
+use arrow::record_batch::RecordBatch;
+use datafusion_common::ScalarValue;
+use std::sync::Arc;
+
+/// Represents the result from an expression
+#[derive(Clone)]
+pub enum ColumnarValue {
Review comment:
I think `ColumnarValue` is really only used for expression evaluation
and perhaps belongs in a physical crate (perhaps `physical_expr`). It is ok for
now, but I don't think it belongs here long term
##########
File path: datafusion/src/physical_plan/aggregates.rs
##########
@@ -40,15 +40,6 @@ use expressions::{
};
use std::sync::Arc;
-/// the implementation of an aggregate function
Review comment:
I like that you are slowly disentangling the physical from the logical
plans
It seems like eventually we will have "physical plan" depending on Exprs and
"logical plan" depending on exprs but not depending on each other 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
