nealrichardson commented on a change in pull request #11971:
URL: https://github.com/apache/arrow/pull/11971#discussion_r802018599
##########
File path: r/R/csv.R
##########
@@ -718,6 +724,9 @@ write_csv_arrow <- function(x,
csv___WriteCSV__RecordBatch(x, write_options, sink)
} else if (inherits(x, "Table")) {
csv___WriteCSV__Table(x, write_options, sink)
+ } else if (inherits(x, "Dataset")) {
Review comment:
```suggestion
} else if (inherits(x, c("Dataset", "arrow_dplyr_query"))) {
```
and fix the checks above. Scanner$create() will handle both. There's no
reason to pull a query into an R data.frame, is there?
##########
File path: r/tests/testthat/test-csv.R
##########
@@ -461,18 +461,23 @@ test_that("Writing a CSV errors when unsupported (yet)
readr args are used", {
append = FALSE,
quote = "all",
escape = "double",
- eol = "\n", ),
- paste("The following arguments are not yet supported in Arrow:
\"append\",",
- "\"quote\", \"escape\", and \"eol\"")
+ eol = "\n",
Review comment:
```suggestion
eol = "\n"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
