alamb commented on a change in pull request #1796:
URL: https://github.com/apache/arrow-datafusion/pull/1796#discussion_r802714477
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1241,11 +1246,20 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
sql: &FunctionArg,
schema: &DFSchema,
) -> Result<Expr> {
- match sql {
- FunctionArg::Named { name: _, arg } => {
- self.sql_expr_to_logical_expr(arg, schema)
+ let arg: &FunctionArgExpr = match sql {
+ FunctionArg::Named { name: _, arg } => arg,
+ FunctionArg::Unnamed(arg) => arg,
+ };
+
+ match arg {
Review comment:
Needed due to https://github.com/sqlparser-rs/sqlparser-rs/pull/378 from
@panarch (so we don't allow crazy stuff like `SELECT * + * from foo` 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
