jvanstraten commented on a change in pull request #12116:
URL: https://github.com/apache/arrow/pull/12116#discussion_r802858907
##########
File path: cpp/src/arrow/memory_pool.h
##########
@@ -109,6 +157,14 @@ class ARROW_EXPORT MemoryPool {
protected:
MemoryPool() = default;
+
+ /// Free a memory region allocated by GetImmutableZeros().
+ ///
+ /// @param buffer Pointer to the start of the allocated memory region
+ /// @param size Allocated size located at buffer. An allocator implementation
Review comment:
Oops, I think my editor is configured to autocomplete using `@param` and
I just didn't notice. a551146
##########
File path: cpp/src/arrow/array/util.cc
##########
@@ -534,6 +533,151 @@ class NullArrayFactory {
std::shared_ptr<Buffer> buffer_;
};
+// mutable version of ImmutableNullArrayFactory
+class NullArrayFactory {
+ private:
+ Result<std::shared_ptr<Buffer>> CreateZeroByteBuffer(size_t
scalar_size_bytes) const {
+ ARROW_ASSIGN_OR_RAISE(auto buffer,
+ AllocateBuffer(length_ * scalar_size_bytes, pool_));
+ std::memset(buffer->mutable_data(), 0, buffer->size());
+ return std::shared_ptr<Buffer>(std::move(buffer));
+ }
+
+ Result<std::shared_ptr<Buffer>> CreateZeroOffsetBuffer(size_t
index_size_bytes) const {
+ ARROW_ASSIGN_OR_RAISE(auto buffer,
+ AllocateBuffer((length_ + 1) * index_size_bytes,
pool_));
+ std::memset(buffer->mutable_data(), 0, buffer->size());
+ return std::shared_ptr<Buffer>(std::move(buffer));
+ }
+
+ Result<std::shared_ptr<Buffer>> CreateZeroBitBuffer(size_t scalar_size_bits)
const {
+ ARROW_ASSIGN_OR_RAISE(auto buffer,
+ AllocateBuffer((length_ * scalar_size_bits + 7) / 8,
pool_));
Review comment:
Changed in 689a8af
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
