pitrou commented on a change in pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#discussion_r802880805
##########
File path: cpp/src/gandiva/annotator.h
##########
@@ -47,6 +47,13 @@ class GANDIVA_EXPORT Annotator {
/// Returns the index of the bitmap in the list of local bitmaps.
int AddLocalBitMap() { return local_bitmap_count_++; }
+ /// Add a pointer to function holder or in holder
+ /// Returns the index of the holder in the holder_pointers vector
+ int AddHolderPointer(void* holder);
+
+ /// Return a pointer to the underlying array containing the holder pointers
+ void** GetHolderPointersArray() { return holder_pointers_.data(); }
Review comment:
Just one question: `holder_pointers_` cannot be resized any further?
Otherwise, this pointer could become invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
