lidavidm commented on a change in pull request #12345:
URL: https://github.com/apache/arrow/pull/12345#discussion_r802919771
##########
File path: cpp/src/arrow/flight/types.h
##########
@@ -165,8 +166,15 @@ struct ARROW_FLIGHT_EXPORT BasicAuth {
std::string username;
std::string password;
- static Status Deserialize(const std::string& serialized, BasicAuth* out);
+ /// \brief Deserialize this message from its wire-format representation.
+ static arrow::Result<BasicAuth> Deserialize(const arrow::util::string_view&
serialized);
+ /// \brief Serialize this message to its wire-format representation.
+ arrow::Result<std::string> SerializeToString() const;
+ ARROW_DEPRECATED("Deprecated in 8.0.0. Use Result-returning overload
instead.")
+ static Status Deserialize(const arrow::util::string_view& serialized,
BasicAuth* out);
Review comment:
Good point - undid that change (I refactored the signature, then added
the deprecation, should've done it the other way around.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
