cyb70289 commented on a change in pull request #12345:
URL: https://github.com/apache/arrow/pull/12345#discussion_r803267348
##########
File path: cpp/src/arrow/flight/types.h
##########
@@ -165,8 +166,15 @@ struct ARROW_FLIGHT_EXPORT BasicAuth {
std::string username;
std::string password;
+ /// \brief Deserialize this message from its wire-format representation.
+ static arrow::Result<BasicAuth> Deserialize(const arrow::util::string_view&
serialized);
Review comment:
Prefer passing by value (in registers) for trivial objects like
`string_view`?
If passing by reference, the callee has to deference the pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
