alamb commented on a change in pull request #1263:
URL: https://github.com/apache/arrow-rs/pull/1263#discussion_r803891260
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -4374,4 +4645,192 @@ mod tests {
BooleanArray::from(vec![Some(true), Some(false), Some(true)])
);
}
+
+ fn get_dict_arraydata(
+ keys: Buffer,
+ key_type: DataType,
+ value_data: ArrayData,
+ ) -> ArrayData {
+ let value_type = value_data.data_type().clone();
+ let dict_data_type =
+ DataType::Dictionary(Box::new(key_type), Box::new(value_type));
+ ArrayData::builder(dict_data_type)
+ .len(3)
+ .add_buffer(keys)
+ .add_child_data(value_data)
+ .build()
+ .unwrap()
+ }
+
+ #[test]
+ fn test_eq_dyn_dictionary_i8_array() {
+ let key_type = DataType::Int8;
Review comment:
https://github.com/apache/arrow-rs/pull/1300 as a proposed PR to make it
better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
