yjshen edited a comment on pull request #1782:
URL:
https://github.com/apache/arrow-datafusion/pull/1782#issuecomment-1035106524
Thanks @alamb for all the thoughts!
~~The PR currently relies on `arrow = { git =
"https://github.com/apache/arrow-rs.git";, rev =
"731e132489b99cd688f884642cf20de52aed24d0" }` since the need to access
ArrayBuilder function. Do you think I should make this PR behind a non-default
feature and just remove the `patch.crates-io` section?~~
Remove the `patch.crates-io` section, move this PR all behind the feature
`row`. I've tested `row` feature succeed locally. While experimenting on `row`,
please add these back before arrow 9.0.3 is released:
```
[patch.crates-io]
arrow = { git = "https://github.com/apache/arrow-rs.git";, rev =
"731e132489b99cd688f884642cf20de52aed24d0" }
parquet = { git = "https://github.com/apache/arrow-rs.git";, rev =
"731e132489b99cd688f884642cf20de52aed24d0" }
```
~~Besides, I'd like to incorporate your `bit_util` comments as well the row
diagram into the PR.~~ [done]
I've listed several TODOs in the PR description, will do as follow-ups.
I think the PR is ready to be merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
