jonkeane commented on a change in pull request #12395:
URL: https://github.com/apache/arrow/pull/12395#discussion_r804001548
##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -45,27 +56,22 @@ fi
# Special hacking to try to reproduce quirks on centos using non-default build
# tooling.
if [[ "$DEVTOOLSET_VERSION" -gt 0 ]]; then
- if [ "`which dnf`" ]; then
- dnf install -y centos-release-scl
- dnf install -y "devtoolset-$DEVTOOLSET_VERSION"
- else
- yum install -y centos-release-scl
- yum install -y "devtoolset-$DEVTOOLSET_VERSION"
- fi
+ $PACKAGE_MANAGER install -y centos-release-scl
+ $PACKAGE_MANAGER install -y "devtoolset-$DEVTOOLSET_VERSION"
fi
-# Install openssl for S3 support
+# Install curl and openssl for S3 support
if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_R_DEV" == "TRUE" ]; then
- if [ "`which dnf`" ]; then
- dnf install -y libcurl-devel openssl-devel
- elif [ "`which yum`" ]; then
- yum install -y libcurl-devel openssl-devel
- elif [ "`which zypper`" ]; then
- zypper install -y libcurl-devel libopenssl-devel
- else
+ if [ "$PACKAGE_MANAGER" = "apt-get" ]; then
apt-get update
apt-get install -y libcurl4-openssl-dev libssl-dev
+ else
+ $PACKAGE_MANAGER install -y libcurl-devel openssl-devel
fi
+fi
Review comment:
```suggestion
```
I think this is covered by the `fi` on line 84 (nee 78)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
