sum12 opened a new pull request #1301:
URL: https://github.com/apache/arrow-rs/pull/1301
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
The PR reuses the csv parser implementation for date64 (which implements
date64 parsing using a format string) for json reader. However the json reader
derives its values from the fields metadata. This is a different approach as
compared to the csv parser and is more flexible as it gives the ability to have
different format string for each field. With the need to have additional attr
added to decoder/reader.
<!---
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
There is no change in the existing parsing flow, however Fields' metadata's
key (`format_string`) is being hijacked for internal purposes. Not sure where
to document this.
<!---
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
