JabariBooker commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r804963653
########## File path: cpp/src/arrow/compute/kernels/copy_data.h ########## @@ -0,0 +1,159 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/array/builder_nested.h" +#include "arrow/array/builder_primitive.h" +#include "arrow/array/builder_time.h" +#include "arrow/array/builder_union.h" +#include "arrow/compute/api.h" +#include "arrow/compute/kernels/codegen_internal.h" +#include "arrow/util/bit_block_counter.h" +#include "arrow/util/bit_run_reader.h" +#include "arrow/util/bitmap.h" +#include "arrow/util/bitmap_ops.h" +#include "arrow/util/bitmap_reader.h" + +namespace arrow { +namespace compute { +namespace internal { + +template <typename Type, typename Enable = void> +struct CopyDataUtils {}; + +template <> +struct CopyDataUtils<BooleanType> { + static void CopyScalar(const Scalar& scalar, const int64_t length, + uint8_t* raw_out_values, const int64_t out_offset) { + const bool value = UnboxScalar<BooleanType>::Unbox(scalar); + bit_util::SetBitsTo(raw_out_values, out_offset, length, value); + } + + static void CopyArray(const DataType&, const uint8_t* in_values, + const int64_t in_offset, const int64_t length, + uint8_t* raw_out_values, const int64_t out_offset) { + arrow::internal::CopyBitmap(in_values, in_offset, length, raw_out_values, out_offset); + } + + static void CopyData(const DataType&, uint8_t* out, const int64_t out_offset, + const ArrayData& in, const int64_t in_offset, + const int64_t length) { + const auto in_arr = in.GetValues<uint8_t>(1, /*absolute_offset=*/0); + arrow::internal::CopyBitmap(in_arr, in_offset + in.offset, length, out, out_offset); + } + + static void CopyData(const DataType&, uint8_t* out, const int64_t out_offset, Review comment: I did some consolidation, but there are still 3 functions (all `CopyData`) in `CopyDataUtils`, one for each passed data representation: `Scalar`, `ArrayData`, and `const uint8*` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
