lidavidm commented on a change in pull request #12379: URL: https://github.com/apache/arrow/pull/12379#discussion_r805012510
########## File path: cpp/src/arrow/compute/kernels/copy_data_internal.h ########## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/compute/kernels/codegen_internal.h" + +namespace arrow { +namespace compute { +namespace internal { + +template <typename Type, typename Enable = void> +struct CopyDataUtils {}; + +template <> +struct CopyDataUtils<BooleanType> { + static void CopyData(const DataType&, const Scalar& in, const int64_t in_offset, Review comment: Do the Scalar overloads need in_offset? ########## File path: cpp/src/arrow/compute/kernels/copy_data_internal.h ########## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/compute/kernels/codegen_internal.h" + +namespace arrow { +namespace compute { +namespace internal { + +template <typename Type, typename Enable = void> +struct CopyDataUtils {}; + +template <> +struct CopyDataUtils<BooleanType> { + static void CopyData(const DataType&, const Scalar& in, const int64_t in_offset, + uint8_t* out, const int64_t out_offset, const int64_t length) { + bit_util::SetBitsTo( + out, out_offset, length, + in.is_valid ? checked_cast<const BooleanScalar&>(in).value : false); + } + + static void CopyData(const DataType&, const uint8_t* in, const int64_t in_offset, + uint8_t* out, const int64_t out_offset, const int64_t length) { + arrow::internal::CopyBitmap(in, in_offset, length, out, out_offset); + } + + static void CopyData(const DataType&, const ArrayData& in, const int64_t in_offset, + uint8_t* out, const int64_t out_offset, const int64_t length) { + const auto in_arr = in.GetValues<uint8_t>(1, /*absolute_offset=*/0); + CopyData(*in.type, in_arr, in_offset, out, out_offset, length); + } +}; + +template <> +struct CopyDataUtils<FixedSizeBinaryType> { + static void CopyData(const DataType& ty, const Scalar& in, const int64_t in_offset, + uint8_t* out, const int64_t out_offset, const int64_t length) { + const int32_t width = checked_cast<const FixedSizeBinaryType&>(ty).byte_width(); + uint8_t* begin = out + (width * out_offset); + const auto& scalar = checked_cast<const arrow::internal::PrimitiveScalarBase&>(in); + // Null scalar may have null value buffer + if (!scalar.is_valid) return; Review comment: The original impl had a `std::memset` in this case to ensure the underlying array is still initialized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
