alamb commented on pull request #1300: URL: https://github.com/apache/arrow-rs/pull/1300#issuecomment-1038126396
> Looks good. The double validation for the dictionary values is a bit unfortunate, but since this is mostly a convenience feature that should be fine. I agree it is unfortunately I'll see if I can make a `new_unchecked()` and then also minimize the checking in `try_new()` to only verify that all indexes are within the range of the dictionary, which Ido think is required for this to be a `safe` API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
