jhorstmann commented on pull request #1305: URL: https://github.com/apache/arrow-rs/pull/1305#issuecomment-1038230548
My suggestion was to remove the `#![allow(clippy::float_equality_without_abs))]`, but also replace assertions like ``` assert!(5.0 - c.value(0) < f64::EPSILON); ``` with ``` assert_eq!(5.0, c.value(0)); ``` where the asserted number can be exactly represented in floating point and where the operation does not involve any rounding. In some earlier rust version the latter assertion would have triggered the `float_cmp` lint, but I don't think it does that anymore for exact numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
