jhorstmann commented on pull request #1263: URL: https://github.com/apache/arrow-rs/pull/1263#issuecomment-1037977838
Looks good. I also find generics to be nicer, mostly because of IDE support, but those would be tricky here since there is no generic trait containing the `value`/`value_unchecked` methods. I was wondering, what does the arrow spec say about dictionary *values* being null? Probably no one uses that combination, but in theory, a valid key could map to a null value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
