alamb commented on a change in pull request #1301:
URL: https://github.com/apache/arrow-rs/pull/1301#discussion_r805337330
##########
File path: arrow/src/json/reader.rs
##########
@@ -1875,6 +1926,15 @@ mod tests {
.unwrap();
assert!(2.0 - bb.value(0) < f32::EPSILON);
assert!(-3.5 - bb.value(1) < f32::EPSILON);
+ let ee = batch
+ .column(e.0)
+ .as_any()
+ .downcast_ref::<Date32Array>()
+ .unwrap();
+ dbg!(ee);
+ assert_eq!(1, ee.value(0));
+ assert_eq!(-1, ee.value(1));
+ assert!(!ee.is_valid(2));
Review comment:
Can you also check the value of index 2
If possible, it would also be helpful to have the tests in terms of the
dates (aka compare to `1970-1-2` rather than a value 1 somehow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
