AlenkaF commented on pull request #12421:
URL: https://github.com/apache/arrow/pull/12421#issuecomment-1040229503


   Thanks for reviewing Joris! Currently:
   
   - imports are removed
   - test is split and skipped in case `zoneinfo` is not available
   - comments for the check in case of `zoneinfo` and `dateutil` objects are 
added
   
   I would leave the handling of `zoneinfo` and `dateutil` objects in 
`TzinfoToString` as is (looking up 'key'  and '_filename' attribute) and plan 
to restructure (to check for an instance of the object) together with `pytz` 
change for https://issues.apache.org/jira/browse/ARROW-15580.
   
   There is a CI error with appveyor: `43 - arrow-dataset-file-csv-test 
(Failed)` in ctest. Don't know what would cause that -will look into it a bit 
more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to