westonpace commented on a change in pull request #12425:
URL: https://github.com/apache/arrow/pull/12425#discussion_r806254305



##########
File path: .github/workflows/cpp.yml
##########
@@ -186,9 +186,9 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - windows-latest
+          - windows-2019
         include:
-          - os: windows-latest
+          - os: windows-2019

Review comment:
       @kszucs I'm pretty sure our builds fail if run on Windows 2022.  They 
specify the 2019 generator and it can't be found.  Do you want to update the 
generator?  Or downgrade the GHA runner?

##########
File path: .github/workflows/go.yml
##########
@@ -134,7 +134,7 @@ jobs:
 
   windows:
     name: AMD64 Windows 2019 Go ${{ matrix.go }}
-    runs-on: windows-latest
+    runs-on: windows-2019

Review comment:
       @emkornfield Does go care if running on Windows 2019 or 2022?

##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
 
   windows:
     name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
-    runs-on: windows-latest
+    runs-on: windows-2019

Review comment:
       @trxcllnt @domoritz Does JS care if running on Windows 2019 or 2022?  If 
it doesn't we could instead just update the build name.

##########
File path: .github/workflows/julia.yml
##########
@@ -46,7 +46,7 @@ jobs:
           - 'nightly'
         os:
           - ubuntu-latest
-          - windows-latest
+          - windows-2019

Review comment:
       @quinnj Does Julia care if we run on Windows 2022 or 2019?

##########
File path: .github/workflows/js.yml
##########
@@ -94,7 +94,7 @@ jobs:
 
   windows:
     name: AMD64 Windows 2019 NodeJS ${{ matrix.node }}
-    runs-on: windows-latest
+    runs-on: windows-2019

Review comment:
       Thanks, I'll leave it at `windows-latest` then.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to