kszucs commented on a change in pull request #12320:
URL: https://github.com/apache/arrow/pull/12320#discussion_r806184056
##########
File path: js/test/unit/generated-data-tests.ts
##########
@@ -54,7 +54,7 @@ describe('Generated Test Data', () => {
describe('List', () => { validateVector(generate.list()); });
describe('Struct', () => { validateVector(generate.struct()); });
describe('DenseUnion', () => { validateVector(generate.denseUnion()); });
- describe('SparseUnion', () => { validateVector(generate.sparseUnion()); });
+ // describe('SparseUnion', () => { validateVector(generate.sparseUnion());
});
Review comment:
Disabled due to https://issues.apache.org/jira/browse/ARROW-15392
Re-enabling this test case will break the JS and integration builds.
##########
File path: cpp/CMakeLists.txt
##########
@@ -123,6 +123,7 @@ list(GET ARROW_LLVM_VERSIONS 0 ARROW_LLVM_VERSION_PRIMARY)
string(REGEX REPLACE "^([0-9]+)(\\..+)?" "\\1" ARROW_LLVM_VERSION_PRIMARY_MAJOR
"${ARROW_LLVM_VERSION_PRIMARY}")
+# TODO(kszucs): should definitely remove this
Review comment:
`.env` is used for docker-compose and we shouldn't depend on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
