nealrichardson commented on a change in pull request #12430:
URL: https://github.com/apache/arrow/pull/12430#discussion_r806878605
##########
File path: r/R/record-batch.R
##########
@@ -123,7 +123,7 @@ RecordBatch <- R6Class("RecordBatch",
},
invalidate = function() {
.Call(`_arrow_RecordBatch__Reset`, self)
- super$invalidate()
+ assign(".:xp:.", NULL, envir = self)
Review comment:
I think you just want to remove it all: these methods, the one place
they're still called, and the C++ functions they call. Since we're doing ALTREP
now, it doesn't make sense to invalidate the Arrow data.
##########
File path: r/R/record-batch.R
##########
@@ -123,7 +123,6 @@ RecordBatch <- R6Class("RecordBatch",
},
invalidate = function() {
Review comment:
Delete these too, and the C++ bindings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
