jonkeane commented on a change in pull request #12366:
URL: https://github.com/apache/arrow/pull/12366#discussion_r807155168
##########
File path: dev/tasks/tasks.yml
##########
@@ -1185,13 +1185,22 @@ tasks:
image: ubuntu-r-only-r
test-r-offline-minimal:
- ci: azure
- template: r/azure.linux.yml
- params:
- r_org: rocker
- r_image: r-base
- r_tag: latest
- flags: '-e TEST_OFFLINE_BUILD=true'
+ ci: azure
+ template: r/azure.linux.yml
+ params:
+ r_org: rocker
+ r_image: r-base
+ r_tag: latest
+ flags: '-e TEST_OFFLINE_BUILD=true'
+
+ test-r-dev-duckdb:
+ ci: github
+ template: docker-tests/github.linux.yml
+ params:
+ env:
+ R_DUCKDB_DEV: TRUE
+ flags: '-e ARROW_SOURCE_HOME="/arrow" -e FORCE_BUNDLED_BUILD=TRUE -e
LIBARROW_BUILD=TRUE'
Review comment:
These are needed because the docker service `ubuntu-r-only-r` is based
on `ubuntu-r` and not the `r` service (so they don't inherit those defaults).
This template works well with `ubuntu-r` and `ubuntu-r-only-r` (all the other
versions of tasks that use this service also use the same template).
I will move all of these flags from here to the actual `ubuntu-r-only-r`
service, since they are effectively needed for that service to do the thing
it's supposed to: work on an arbitrary ubuntu that we have dockerfiles for, but
only build as a consequence of installing the R package and don't build
libarrow first). So that should look better and be easier to use in the future.
I'm using `ubuntu-r-only-r` because DuckDB needs python to build and the `r`
service doesn't (yet) have python installed when it builds, there _might_ be a
rocker|rstudio image we could use that has python installed, but I didn't want
to poke each and see if it does to find one that would work.
We probably could / should unify these (r, ubuntu-r, and ubuntu-r-only-r) at
some point, but I would rather not do that in this PR (but will make a jira for
that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
