tustvold commented on a change in pull request #1838:
URL: https://github.com/apache/arrow-datafusion/pull/1838#discussion_r807337681
##########
File path: datafusion/benches/parquet_query_sql.rs
##########
@@ -229,7 +229,7 @@ fn criterion_benchmark(c: &mut Criterion) {
});
}
- // Clean up temporary file if any
+ // Temporary file must outlive the benchmarks, it is deleted when dropped
Review comment:
This was review feedback from
https://github.com/apache/arrow-datafusion/pull/1738#discussion_r807047918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
