cyb70289 commented on a change in pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#discussion_r807642118
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
##########
@@ -28,13 +28,25 @@
#include "arrow/util/checked_cast.h"
#include "arrow/util/formatting.h"
#include "arrow/util/logging.h"
+#include "arrow/util/string.h"
namespace arrow {
using internal::StringFormatter;
namespace compute {
+template <typename... Elements>
+std::string MakeArray(Elements... elements) {
Review comment:
Looks this function is not very necessary. Can we directly write the
test string at caller side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
