gsserge opened a new pull request #1324: URL: https://github.com/apache/arrow-rs/pull/1324
# Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/1255 # Rationale for this change It's beneficial to run clippy and compiler lints as strict as possible. # What changes are included in this PR? This PR drops `#![allow(dead_code)]`, which is the last top level `allow` attribute in the `arrow` crate. Unfortunately, it's the most difficult one to deal with, because there's a lot of code that exists and sometimes even has tests, but it's neither pub exported nor used anywhere. I don't feel comfortable removing it (except for the obvious cases like the unused time consts), that's why I've decided to use local `#[allow(dead_code)]` instead. The existing code is left intact, because it might be needed in the future, while overall the linting process gets more strict. # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
