jvanstraten commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809201954
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
continue()
endif()
- # For debugging
- message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+ # Allow values to be overridden to test specific versions during development
Review comment:
It doesn't really belong in this PR, so I'm fine with removing it, but
it does make it harder to verify compatibility with 3.0.0 for future changes
manually or using CI (assuming there is not already a better way for overriding
versions.txt).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
