viirya commented on pull request #1330: URL: https://github.com/apache/arrow-rs/pull/1330#issuecomment-1043252680
> The only potential concern I have here is that the `take_iter()s` use `value()` instead of `value_unchecked()` -- though perhaps we can merge this PR in and then add some additional unsafe / skipping bounds checking if it turns out to be in anyone's critical path / shows up in profiles Thanks @alamb . As we don't know if the keys in key iterator are fully in the valid range, seems we cannot skipping bounds check in `take_iter`? If it is critical, maybe we can have `take_iter_unchecked` in the future if it is necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
