Ted-Jiang commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r809632924



##########
File path: datafusion/Cargo.toml
##########
@@ -81,6 +81,7 @@ num-traits = { version = "0.2", optional = true }
 pyo3 = { version = "0.15", optional = true }
 tempfile = "3"
 parking_lot = "0.12"
+croaring = "0.5.1"

Review comment:
       @alamb Thanks for your reply. I agree It 's complicated for add a new 
dependency `clang` into datafusion.
   IMO, we still need an high-efficiency bitmap implement `roarling-bitmap`, 
like IOx and other high-end OLAP systems to do some optimize like late 
materialization. Maybe we should change `croaring ` to `roarling-rs` 
(completely written in rust, won't cost too mush compile time, i also find 
datafusion compile\build parallel ), maybe one day it will catch up with 
`croaring ` 😂




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to